Change pdflib puppeteer #2536

SolidProgramming · 2024-09-16T06:20:28Z

No description provided.

[~] Changed PDF Test to use puppeteer

[~] Changed PDF Test to use puppeteer CactuseSecurity#2322

…gramming/firewall-orchestrator into change_pdflib_puppeteer

tpurschke

On ubuntu 24.04 I get the following test failure. will test with other OSes

    2024-09-16T09:45:00+02:00 Info - Startup (HtmlToPdfTest.cs in line 18), Downloading headless Browser...
    2024-09-16T09:45:14+02:00 Info - Test Log (HtmlToPdfTest.cs in line 22), starting PDF generation
  
      Failed GeneratePdf [15 s]
      Error Message:
       PuppeteerSharp.ProcessException : Failed to launch browser!
      Stack Trace:
         at PuppeteerSharp.States.ProcessStartingState.StartCoreAsync(LauncherBase p) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/States/ProcessStartingState.cs:line 83
       at PuppeteerSharp.States.ProcessStartingState.StartCoreAsync(LauncherBase p) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/States/ProcessStartingState.cs:line 89
       at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/Launcher.cs:line 72
       at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/Launcher.cs:line 105
       at FWO.Test.HtmlToPdfTest.GeneratePdf() in /usr/local/fworch/test/csharp/FWO.Test/HtmlToPdfTest.cs:line 26
       at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
       at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
       at NUnit.Framework.Internal.AsyncToSyncAdapter.Await[TResult](Func`1 invoke)
       at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
       at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
       at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
       at NUnit.Framework.Internal.Commands.BeforeTestCommand.Execute(TestExecutionContext context)
       at NUnit.Framework.Internal.Execution.SimpleWorkItem.<>c__DisplayClass3_0.<PerformWork>b__0()
       at NUnit.Framework.Internal.ContextUtils.<>c__DisplayClass1_0`1.<DoIsolated>b__0(Object _)
       at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
    --- End of stack trace from previous location ---
       at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
       at NUnit.Framework.Internal.ContextUtils.DoIsolated(ContextCallback callback, Object state)
       at NUnit.Framework.Internal.ContextUtils.DoIsolated[T](Func`1 func)
       at NUnit.Framework.Internal.Execution.SimpleWorkItem.PerformWork()
  
      Standard Output Messages:
     2024-09-16T09:45:00+02:00 Info - Startup (HtmlToPdfTest.cs in line 18), Downloading headless Browser...
     2024-09-16T09:45:14+02:00 Info - Test Log (HtmlToPdfTest.cs in line 22), starting PDF generation
  
  
    2024-09-16T09:45:00+02:00 Info - Startup (LockTest.cs in line 29), Starting Lock Tests...
    2024-09-16T09:45:02+02:00 Debug - TEST_TITLE (LockTest.cs in line 71), TEST_TEXT
  
  
    Failed!  - Failed:     1, Passed:    58, Skipped:     0, Total:    59, Duration: 17 s - FWO.Test.dll (net8.0)
  stdout_lines: <omitted>

…-orchestrator into change_pdflib_puppeteer

tpurschke

When doing a fresh install on ubuntu 22.04 I get the expected error during pdf test.
But when trying to generate a PDF in reporting UI, I get the error:

2024-12-30T14:38:53.608356+00:00 ubu22 fworch-ui:   ---
2024-12-30T14:38:53.608370+00:00 ubu22 fworch-ui:  Exception thrown:
2024-12-30T14:38:53.608383+00:00 ubu22 fworch-ui:   WebSocketException
2024-12-30T14:38:53.608396+00:00 ubu22 fworch-ui:  Message:
2024-12-30T14:38:53.608409+00:00 ubu22 fworch-ui:   The remote party closed the WebSocket connection without completing the close handshake.
2024-12-30T14:38:53.608422+00:00 ubu22 fworch-ui:  Stack Trace:
2024-12-30T14:38:53.608436+00:00 ubu22 fworch-ui:   at System.Net.WebSockets.ManagedWebSocket.ThrowEOFUnexpected()
2024-12-30T14:38:53.608452+00:00 ubu22 fworch-ui:     at System.Net.WebSockets.ManagedWebSocket.EnsureBufferContainsAsync(Int32 minimumRequiredBytes, CancellationToken cancellationToken)
2024-12-30T14:38:53.608466+00:00 ubu22 fworch-ui:     at System.Runtime.CompilerServices.PoolingAsyncValueTaskMethodBuilder`1.StateMachineBox`1.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
2024-12-30T14:38:53.608479+00:00 ubu22 fworch-ui:     at System.Net.WebSockets.ManagedWebSocket.ReceiveAsyncPrivate[TResult](Memory`1 payloadBuffer, CancellationToken cancellationToken)
2024-12-30T14:38:53.608493+00:00 ubu22 fworch-ui:     at System.Runtime.CompilerServices.PoolingAsyncValueTaskMethodBuilder`1.StateMachineBox`1.System.Threading.Tasks.Sources.IValueTaskSource<TResult>.GetResult(Int16 token)
2024-12-30T14:38:53.608506+00:00 ubu22 fworch-ui:     at System.Threading.Tasks.ValueTask`1.ValueTaskSourceAsTask.<>c.<.cctor>b__4_0(Object state)
2024-12-30T14:38:53.608519+00:00 ubu22 fworch-ui:  --- End of stack trace from previous location ---
2024-12-30T14:38:53.608532+00:00 ubu22 fworch-ui:     at GraphQL.Client.Http.Websocket.GraphQLHttpWebSocket.ReceiveWebsocketMessagesAsync() in /_/src/GraphQL.Client/Websocket/GraphQLHttpWebSocket.cs:line 513
2024-12-30T14:44:28.822372+00:00 ubu22 fworch-ui:  2024-12-30T14:44:28+00:00 Audit - AuthenticateUser (AuthStateProvider.cs in line 38), user admin successfully authenticated
2024-12-30T14:44:38.492313+00:00 ubu22 fworch-ui:  2024-12-30T14:44:38+00:00 Error - Export Report (MainLayout.razor in line 349), User: admin, Role: admin, Unspecified error occured:
2024-12-30T14:44:38.492390+00:00 ubu22 fworch-ui:   ---
2024-12-30T14:44:38.492431+00:00 ubu22 fworch-ui:  Exception thrown:
2024-12-30T14:44:38.492460+00:00 ubu22 fworch-ui:   ProcessException
2024-12-30T14:44:38.492503+00:00 ubu22 fworch-ui:  Message:
2024-12-30T14:44:38.492552+00:00 ubu22 fworch-ui:   Failed to launch browser!
2024-12-30T14:44:38.492589+00:00 ubu22 fworch-ui:  Stack Trace:
2024-12-30T14:44:38.492622+00:00 ubu22 fworch-ui:   at PuppeteerSharp.States.ProcessStartingState.StartCoreAsync(LauncherBase p) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/States/ProcessStartingState.cs:line 83
2024-12-30T14:44:38.492662+00:00 ubu22 fworch-ui:     at PuppeteerSharp.States.ProcessStartingState.StartCoreAsync(LauncherBase p) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/States/ProcessStartingState.cs:line 89
2024-12-30T14:44:38.492697+00:00 ubu22 fworch-ui:     at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/Launcher.cs:line 77
2024-12-30T14:44:38.492736+00:00 ubu22 fworch-ui:     at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/Launcher.cs:line 110
2024-12-30T14:44:38.492770+00:00 ubu22 fworch-ui:     at FWO.Report.ReportBase.CreatePDFViaPuppeteer(String html, PaperFormat format) in /usr/local/fworch/lib/files/FWO.Report/ReportBase.cs:line 243
2024-12-30T14:44:38.492804+00:00 ubu22 fworch-ui:     at FWO.Report.ReportBase.ToPdf(String html, PaperFormat format) in /usr/local/fworch/lib/files/FWO.Report/ReportBase.cs:line 293
2024-12-30T14:44:38.492838+00:00 ubu22 fworch-ui:     at FWO.Ui.Pages.Reporting.ReportExport.<Export>b__22_0() in /usr/local/fworch/ui/files/FWO.UI/Pages/Reporting/ReportExport.razor:line 175
2024-12-30T14:44:38.494061+00:00 ubu22 fworch-ui:  FWORCHAlert - source: "ui", userId: "3", title: "Export Report", description: "Unclassified error: : Failed to launch browser!  . See log for details!", alertCode: "UiError"

…gramming/firewall-orchestrator into change_pdflib_puppeteer

SolidProgramming · 2024-12-30T15:23:13Z

@tpurschke Can you pull with my latest changes to test? This works now for my ubuntu vm.

tpurschke · 2024-12-30T15:35:02Z

@tpurschke Can you pull with my latest changes to test? This works now for my ubuntu vm.

no, same error in my (upgrade) test, which is BTW the same error the pdf test throws.
Could this be caused by missing dependencies or did you/ @alf-cactus already install these during upgrade/install?

For systems like Linux, additional dependencies (e.g., shared libraries required by Chromium) might be missing. Ensure all necessary libraries are installed. Examples include libnss3, libatk-bridge2.0-0, libgbm1, etc.

If not, send me a list of packages (for ubuntu 22.04) and I can test if this helps.

   A total of 1 test files matched the specified pattern.
      Failed GeneratePdf [433 ms]
      Error Message:
       PuppeteerSharp.ProcessException : Failed to launch browser!
      Stack Trace:
         at PuppeteerSharp.States.ProcessStartingState.StartCoreAsync(LauncherBase p) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/States/ProcessStartingState.cs:line 83
       at PuppeteerSharp.States.ProcessStartingState.StartCoreAsync(LauncherBase p) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/States/ProcessStartingState.cs:line 89
       at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/Launcher.cs:line 77
       at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options) in /home/runner/work/puppeteer-sharp/puppeteer-sharp/lib/PuppeteerSharp/Launcher.cs:line 110
       at FWO.Test.HtmlToPdfTest.GeneratePdf() in /usr/local/fworch/test/csharp/FWO.Test/HtmlToPdfTest.cs:line 45
       at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
       at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
       at NUnit.Framework.Internal.AsyncToSyncAdapter.Await[TResult](Func`1 invoke)
       at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
       at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
       at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
       at NUnit.Framework.Internal.Execution.SimpleWorkItem.<>c__DisplayClass3_0.<PerformWork>b__0()
       at NUnit.Framework.Internal.ContextUtils.<>c__DisplayClass1_0`1.<DoIsolated>b__0(Object _)
       at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
    --- End of stack trace from previous location ---
       at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
       at NUnit.Framework.Internal.ContextUtils.DoIsolated(ContextCallback callback, Object state)
       at NUnit.Framework.Internal.ContextUtils.DoIsolated[T](Func`1 func)
       at NUnit.Framework.Internal.Execution.SimpleWorkItem.PerformWork()
  
      Standard Output Messages:
     2024-12-30T16:25:49+01:00 Info - Test Log (HtmlToPdfTest.cs in line 25), OS: Unix 5.15.0.130

tpurschke · 2024-12-30T16:55:07Z

after issuing the following command (still ubuntu 22.04), the test as well as the pdf generation within the UI works perfectly:

        sudo apt install -y   ca-certificates   fonts-liberation   libappindicator3-1   libasound2   libatk1.0-0   libatk-bridge2.0-0   libcups2   libdbus-1-3   libdrm2   libgbm1   libglib2.0-0   libnspr4   libnss3   libx11-xcb1   libxcomposite1   libxcursor1   libxdamage1   libxext6   libxfixes3   libxi6   libxrandr2   libxrender1   libxtst6   lsb-release   wget   xdg-utils

This means we need to determine for each supported platform which packages are needed and install them via ansible.

I am confident that we can get this running - so suggest to merge which makes it easier to make the necessary changes in ansible playbooks.

SolidProgramming and others added 9 commits September 10, 2024 13:26

[+] Added puppeteersharp for pdf creation CactuseSecurity#2322

f1126c6

[~] Changed the spinner controls to hide it's text

b9234c0

[~] Moved the PDF generation with puppeteer to reportbase

6fc08c4

[+] Added overloads for pdf creation with puppeteer

1e9ef5b

[+] Added custom pdf size for puppeteer

ed5ac52

[-] Removed wkhtml

105dedb

[~] Changed PDF Test to use puppeteer

[-] Removed wkhtml

1c56417

[~] Changed PDF Test to use puppeteer CactuseSecurity#2322

Merge branch 'change_pdflib_puppeteer' of https://github.com/SolidPro…

454e924

…gramming/firewall-orchestrator into change_pdflib_puppeteer

[~] Fixed PDF generation test

6ae7dbc

SolidProgramming requested a review from tpurschke September 16, 2024 06:20

tpurschke and others added 3 commits September 16, 2024 09:35

Merge branch 'develop' into change_pdflib_puppeteer

50d62be

[~] Github Test Build fix?

6e28414

Merge branch 'change_pdflib_puppeteer' of https://github.com/SolidPro…

0e3f3f9

…gramming/firewall-orchestrator into change_pdflib_puppeteer

tpurschke requested changes Sep 16, 2024

View reviewed changes

SolidProgramming marked this pull request as draft September 16, 2024 07:59

SolidProgramming self-assigned this Sep 16, 2024

SolidProgramming mentioned this pull request Sep 16, 2024

lib pdf generation - replace deprecatd wkhtml with alternative solution #2322

Open

17 tasks

SolidProgramming added 13 commits September 17, 2024 14:15

test push

de2002b

test push

7a4edea

test push

75e2f99

test push

e1b4f7f

test push

9229cb5

test push

c1974e1

test push

c6beba7

test push

be08ae9

[~] test push

a660446

[~] test push

3eb133a

[~] test push

61379b3

[~] test push

4225d29

.

9323193

SolidProgramming and others added 20 commits December 13, 2024 16:07

Removed chrome download on startup

2e09573

[~] Changed path

b361ad6

.

ec6f321

.

8f14641

.

ef1137a

.

f1ae5c5

.

c6811e9

.

0be4977

.

e561a28

.

ae49dc5

.

d9b2846

.

13f5bc1

.

fc6ddf1

Test: Try all available paper formats

c7a934c

Test: Log output paperformat

2e24dcd

Merge branch 'develop' of https://github.com/CactuseSecurity/firewall…

71d27fa

…-orchestrator into change_pdflib_puppeteer

Project: Remove Haukcode.WkHtmlToPdfDotNet references

72e4115

Merge branch 'develop' into change_pdflib_puppeteer

8f4d7e3

Merge branch 'develop' into change_pdflib_puppeteer

ea08fff

Merge branch 'develop' into change_pdflib_puppeteer

33552fe

tpurschke self-requested a review December 30, 2024 14:45

tpurschke reviewed Dec 30, 2024

View reviewed changes

SolidProgramming added 2 commits December 30, 2024 16:12

test no sandobx

d77d963

Merge branch 'change_pdflib_puppeteer' of https://github.com/SolidPro…

b75a9e7

…gramming/firewall-orchestrator into change_pdflib_puppeteer

no sandbox in test

327bdea

tpurschke marked this pull request as ready for review December 30, 2024 16:59

tpurschke merged commit 40c69e5 into CactuseSecurity:develop Dec 30, 2024
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change pdflib puppeteer #2536

Change pdflib puppeteer #2536

SolidProgramming commented Sep 16, 2024

tpurschke left a comment

tpurschke left a comment

SolidProgramming commented Dec 30, 2024

tpurschke commented Dec 30, 2024 •

edited

Loading

tpurschke commented Dec 30, 2024 •

edited

Loading

Change pdflib puppeteer #2536

Change pdflib puppeteer #2536

Conversation

SolidProgramming commented Sep 16, 2024

tpurschke left a comment

Choose a reason for hiding this comment

tpurschke left a comment

Choose a reason for hiding this comment

SolidProgramming commented Dec 30, 2024

tpurschke commented Dec 30, 2024 • edited Loading

tpurschke commented Dec 30, 2024 • edited Loading

tpurschke commented Dec 30, 2024 •

edited

Loading

tpurschke commented Dec 30, 2024 •

edited

Loading